Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCKERFILE_GLOB_PATTERN is too permissive #134

Closed
freeformz opened this issue Oct 3, 2017 · 3 comments
Closed

DOCKERFILE_GLOB_PATTERN is too permissive #134

freeformz opened this issue Oct 3, 2017 · 3 comments

Comments

@freeformz
Copy link

We have a dockerfile.go file in at least one repo and it's being detected as belonging to this plugin instead of the Go plugin.

This is likely because the current DOCKERFILE_GLOB_PATTERN is too permissive.

@freeformz
Copy link
Author

dockerfile_test.go is also detected as a Dockerfile, instead of a .go file.

@chrisdias
Copy link
Member

this is also painful when developing the docker extension :)

@dlech
Copy link
Contributor

dlech commented Oct 21, 2017

@lostintangent, what is the motivation for 950d9f0?

It seems that the standard format is either Dockerfile or *.dockerfile.

I'm going to suggest using only the most common filenames in the extension and users can use the language-specific settings in VSCode if they need to match other files.

dlech added a commit to dlech/vscode-docker that referenced this issue Oct 21, 2017
The current matches are too permissive and cause false positives.

Fixes microsoft#134
chrisdias pushed a commit that referenced this issue Nov 8, 2017
The current matches are too permissive and cause false positives.

Fixes #134
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants