Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Dockerfile.<some-env> #248

Closed
wants to merge 1 commit into from

Conversation

MattMorgis
Copy link

I think this closes #102 and #192

It should add icon and syntax support for Dockerfile.<some-env>

Before:
screen shot 2018-04-10 at 3 53 21 pm

After:
screen shot 2018-04-10 at 3 53 05 pm

@chrisdias
Copy link
Member

@MattMorgis thanks for the PR. We've gone back and forth on the glob pattern here (see #193 (comment) for example). There's a workaround to use files.associations in settings:

    "files.associations": {
        "Dockerfile-centos": "dockerfile"
    }

Another idea was to have a setting that let you customize the glob pattern for your environment that people seemed to like (#102 (comment)). I'd be more inclined to take a PR for that than switching up the glob pattern again.

@StephenWeatherford
Copy link
Contributor

@chrisdias, @fiveisprime I don't see the drawback of adding * to the default dockerfile glob pattern, whether or not we add customization of it. I'd like to get this merged (with minor changes). Do you disagree? The compose file glob already has that:

export const FROM_DIRECTIVE_PATTERN = /^\sFROM\s([\w-/:])(\sAS\s*[a-z][a-z0-9-_\.])?$/i;
export const COMPOSE_FILE_GLOB_PATTERN = '**/[dD]ocker-[cC]ompose
.{yaml,yml}';
export const DOCKERFILE_GLOB_PATTERN = '**/{*.dockerfile,[dD]ocker[fF]ile}';

@StephenWeatherford StephenWeatherford self-assigned this Jul 13, 2018
@chrisdias
Copy link
Member

The pattern used to be more permissive, but then it was too intrusive. See #134 for the original issue where we changed it to what it is today. I like the idea of making this a setting so that it can be controlled by the user.

@MattMorgis
Copy link
Author

I like the idea of making this a setting, too. I will poke around and update this PR.

@ejizba
Copy link
Contributor

ejizba commented Nov 2, 2018

FYI this PR was created before our recent switch from Travis CI to Azure Dev Ops. Push a commit (merging with master or addressing comments) and the "checks" for this PR will be updated

@ejizba
Copy link
Contributor

ejizba commented May 6, 2019

Closing this PR since this solution is too intrusive as mentioned above and hasn't had any recent activity. We're actively investigating the alternative approach to add settings for these glob patterns

@ejizba ejizba closed this May 6, 2019
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom file names
4 participants