Remapping of escape character not handled

[paulcallen]

put this at the top of a docker file: # escape=`

and it remaps the escape character such that windows file paths can exist as c:\foo. Really nice feature.
Unfortunately this plug-in does not recognize this and as a result it thinks \f is an invalid escape sequence.

[rcjsuen]

@paulcallen Hi, could you attach a screenshot and your Dockerfile to more clearly identify what the problem is?

[paulcallen]

looks like it is for quoted strings as I have other paths that do not show an error,

[thomashillyer]

I think this is the same as issue #75

[rcjsuen]

@thomashillyer I don't think that's quite the same. I feel like #75 is a parsing issue with quotes and backslashes whereas this #245 is due to the parser not being capable of reading Dockerfile's escape parser directive (understandably so in my opinion).

[thomashillyer]

@rcjsuen but presumably if the Dockerfile's escape parser was read then the issue in #75 would also be solved because backslashes wouldn't be treated as escape characters

I suppose then the issue arises when someone wants to use the backslash as an escape character in a command they are running

[rcjsuen]

@thomashillyer Yeah, you basically need a way to tell the grammar when you're in some RUN instruction or not for #75. I'm assuming that's not trivial or even possible to describe.

For this issue #245 you need a way to teach the grammar about Dockerfile escape parser directives. That sounds equally difficult and non-standard for a grammar but I could be wrong...

[StephenWeatherford]

It's not clear how many people this is affecting. Is it blocking people?

[paulcallen]

not blocking for me. It was more of an fyi for you. if it is easy to fix then go for it, if not then that is fine also,

[dcormier]

I have this problem. It's definitely frustrating, but, as it doesn't not actually prevent editing the file, I wouldn't classify it as blocking for me. It just completely breaks syntax highlighting.

[StephenWeatherford]

From a quick look it doesn't look like this would be very easy, but not an expert in g4. If someone wants to give it a shot, go for it!

[bwateratmsft]

I filed microsoft/vscode#82985 and will close this issue as external.