Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax colorization stops working after RUN command in visual studio code with docker 0.0.27 plugin #292

Closed
ctgarvey opened this issue Jul 3, 2018 · 13 comments
Assignees

Comments

@ctgarvey
Copy link

ctgarvey commented Jul 3, 2018

Ive reloaded the docker 0.0.27 plugin in visual studio code 1.24.1 (running on windows 10 1803 / 17134)
but its still not bringing the very useful linting /colouring back to life. problem seems to be somewhere in here:
image

RUN stop-service MSSQL$SQLEXPRESS ;
set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpdynamicports -value '' ; set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpport -value 1433 ;
set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver' -name LoginMode -value 2;

CMD .\start -sa_password $env:sa_password -ACCEPT_EULA $env:ACCEPT_EULA -attach_dbs "$env:attach_dbs" -Verbose

EXPOSE 1433 1434 3389 5985 5986
EXPOSE 1433/udp 1434/udp 5985/udp 5986/udp

@rcjsuen
Copy link
Contributor

rcjsuen commented Jul 3, 2018

@ctgarvey The syntax highlighting feature and the linting feature are two unrelated features and they do not depend on each other to work.

Are you seeing an invalid linting error that shouldn't be there because docker build will build the image? Or are you just seeing a problem with the colouring?

@ctgarvey
Copy link
Author

ctgarvey commented Jul 5, 2018

hi there, my bad . I am just seeing a problem with the colouring. Image builds fine.

@rcjsuen
Copy link
Contributor

rcjsuen commented Jul 5, 2018

Hi, @ctgarvey. Thank you for checking. From what I can see, your issue is another variation of #75.

@StephenWeatherford
Copy link
Contributor

@rcjsuen Do you want me to assign issues like this to you? Thanks.

@rcjsuen
Copy link
Contributor

rcjsuen commented Jul 13, 2018

@StephenWeatherford I don’t think this is a linting issue. It looks like a colouring issue. Syntax highlight is not provided by the language server.

If you feel there is a linting issue here, please let me know but I do not currently feel there is anything for me to do here.

@StephenWeatherford
Copy link
Contributor

Good to know, thanks.

@StephenWeatherford
Copy link
Contributor

Related to #245?

@StephenWeatherford StephenWeatherford modified the milestones: 0.2.0, 0.1.0 Jul 25, 2018
@PrashanthCorp
Copy link
Contributor

I think so. I un-escaped the '\' and it seems more sane now.

image

@StephenWeatherford
Copy link
Contributor

We need to enter an issue against Moby, then move to next milestone.

@PrashanthCorp
Copy link
Contributor

This needs to be fixed in vscode, at the tmLanguage.json for docker. See this comment

@rcjsuen
Copy link
Contributor

rcjsuen commented Oct 18, 2019

Can someone please change the title of this issue so that it reflects that the problem is a syntax highlighting issue and not a linting issue? Thanks!

@StephenWeatherford StephenWeatherford changed the title Linting stops working after RUN command in visual studio code with docker 0.0.27 plugin Syntax colorization stops working after RUN command in visual studio code with docker 0.0.27 plugin Oct 18, 2019
@StephenWeatherford
Copy link
Contributor

I've now got some experience with colorization, feel free to ask questions. Might or might not be easy to fix.

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Oct 21, 2019

Based on @PrashanthCorp 's comment it seems like this is a dupe of #75.

@bwateratmsft bwateratmsft removed this from the Future milestone Nov 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants