Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to V91 of devtools #414

Merged
merged 7 commits into from
Jun 16, 2021
Merged

update to V91 of devtools #414

merged 7 commits into from
Jun 16, 2021

Conversation

bgoddar
Copy link
Contributor

@bgoddar bgoddar commented Jun 11, 2021

This PR updates the included version of the Devtools from v88 to v91. This includes

  • Updating the devtools files to be a standard debug build of devtools instead of a modified release build
  • Updating Polyfills to new code and file structure

Notable additions in this update:

  • CSS grid and flexbox features
  • Tooltips
  • Welcome tab replaces What's new

@@ -65,12 +64,6 @@ async function copyStaticFiles() {

const sourceFilesPath = path.normalize(__dirname + '/out/edge/src');

const toolsSrcDir = path.normalize(`${sourceFilesPath}/third_party/devtools-frontend/src/front_end/`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the "third_party" directory from bundled files, as this is not needed

@bgoddar bgoddar marked this pull request as ready for review June 15, 2021 19:09
@bgoddar bgoddar force-pushed the bgoddar/updateDevtoolsVersion branch from 6e00176 to fd7dc1a Compare June 15, 2021 21:14
Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have one small request but not blocking

scripts/downloadAndExtractEdge.js Show resolved Hide resolved
@bgoddar bgoddar merged commit 1ac9adc into master Jun 16, 2021
@bgoddar bgoddar deleted the bgoddar/updateDevtoolsVersion branch June 24, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants