Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Extension Bundle size #418

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Reduce Extension Bundle size #418

merged 4 commits into from
Jun 15, 2021

Conversation

bgoddar
Copy link
Contributor

@bgoddar bgoddar commented Jun 15, 2021

This PR reduces our extension bundle size in 2 ways:

  1. Add a .vscodeignore to the project. Without this file, the vsce package bundles everything inside the project directory (node modules, documentation pictures, source code, etc). This allows us to specify which directories and files are needed at runtime, and exclude everything else.
  2. Minify the devtools code using uglify-js. This was added because the update to v91 forces us to use a debug build of devtools for polyfills. This allows us to minify again after applying polyfills

This reduces our vsix size to <8MB when used in conjunction with the update to v91 in #414

@bgoddar bgoddar force-pushed the bgoddar/minifyOuput branch from 36275da to 2a8f1c4 Compare June 15, 2021 19:39
Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a small change, but otherwise LGTM

.vscodeignore Show resolved Hide resolved
@mliao95 mliao95 self-requested a review June 15, 2021 20:27
Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgoddar bgoddar merged commit 7669e4d into master Jun 15, 2021
@bgoddar bgoddar deleted the bgoddar/minifyOuput branch June 24, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants