Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show proper progress title and location when creating project #1167

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: Show proper progress title and location when creating project #1167

merged 1 commit into from
Jan 25, 2022

Conversation

CsCherrYY
Copy link
Collaborator

@CsCherrYY CsCherrYY added the UX label Jan 25, 2022
@CsCherrYY CsCherrYY added this to the January 2022 milestone Jan 25, 2022
@CsCherrYY CsCherrYY changed the title fix: Show proper progress title and location fix: Show proper progress title and location when creating project Jan 25, 2022
@CsCherrYY CsCherrYY mentioned this pull request Jan 25, 2022
Closed
35 tasks
Eskibear
Eskibear approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider extract optional parameters into on options in the future.

@CsCherrYY CsCherrYY merged commit df82f2a into main Jan 25, 2022
@CsCherrYY CsCherrYY deleted the cs-create-ux branch January 25, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear Eskibear approved these changes

@jdneo jdneo Awaiting requested review from jdneo jdneo is a code owner

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

Assignees
No one assigned
Labels
UX
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@CsCherrYY @Eskibear