Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the experience with a trackpad #228

Closed
Tyriar opened this issue Mar 13, 2021 · 0 comments · Fixed by #256
Closed

Improve the experience with a trackpad #228

Tyriar opened this issue Mar 13, 2021 · 0 comments · Fixed by #256
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 13, 2021

On a macbook if you use 2 fingers and drag to the right and then go up, it either won't start scrolling or it will suddenly. I'm guessing there is some filtering of events happening depending on the direction, but I don't think you want to do this for trackpads as it feels clunky unless you also support "diagonal scrolls".
@Tyriar Tyriar self-assigned this Mar 17, 2021
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 17, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 17, 2021
Tyriar added a commit that referenced this issue Mar 17, 2021
@Tyriar
Respect vertical scroll events regardless of deltaX
03ebf9a 
Fixes #228
@Tyriar Tyriar mentioned this issue Mar 17, 2021
Merged
lramos15 pushed a commit that referenced this issue Mar 18, 2021
@Tyriar
Greatly improve scroll experience on trackpads (#256)
ead9f4b 
* Fix typo in scroll bar file name

* Respect vertical scroll events regardless of deltaX

Fixes #228

* Support ballistic scroll

Fixes #227

* Differentiate mouse wheel and touch scrolls

* Restrict trackpad scroll support to macs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Greatly improve scroll experience on trackpads microsoft/vscode-hexeditor
1 participant
@Tyriar