Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve scroll experience on trackpads #256

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 17, 2021

Adds support for diagonal and ballistic (smooth) scroll events:

recording (12)

Fixes #228
Fixes #227

@Tyriar Tyriar added this to the March 2021 milestone Mar 17, 2021
@Tyriar Tyriar requested a review from lramos15 March 17, 2021 19:51
@Tyriar Tyriar self-assigned this Mar 17, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 17, 2021

I didn't test this with a mouse, it will probably end up scrolling multiple lines on some machines/browsers, depending on how they fire WheelEvent.

Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The gif looks really smooth :)

@lramos15
Copy link
Member

I can test it on a mouse, give me a few minutes

@lramos15
Copy link
Member

Yeah I would say with a mouse wheel it feels a lot more broken than it does on main. You can scroll super slowly but anything else you jump multiple lines. I would recommend you try it if possible to see what I mean

Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to hold off on merging this until we get a better experience for both mouse and trackpad. As this seems to trade one for the other.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 17, 2021

Sounds good, I'll improve on mouse a bit later.

@Tyriar Tyriar requested a review from lramos15 March 18, 2021 13:05
@Tyriar
Copy link
Member Author

Tyriar commented Mar 18, 2021

@lramos15 ready for another one, not the best fix as it's much harder than you'd expect to differentiate hardware wheel/trackpad, but it should make the experience good on mac.

Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a better fix to me and I'm happy to have trackpad support. Will need to look into something similar to xterm.js in the future to increase the experience even more by always snapping to a line.

@lramos15 lramos15 merged commit ead9f4b into main Mar 18, 2021
@lramos15 lramos15 deleted the tyriar/scroll branch March 18, 2021 14:20
@Tyriar
Copy link
Member Author

Tyriar commented Mar 18, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the experience with a trackpad Support ballistic scrolling
2 participants