Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hex editor fails to display file contents when backgrounded, foregrounded and scrolled #319

Closed
joyceerhl opened this issue Nov 30, 2021 · 0 comments
Closed

Hex editor fails to display file contents when backgrounded, foregrounded and scrolled #319

joyceerhl opened this issue Nov 30, 2021 · 0 comments

Comments

@joyceerhl
Copy link

Testing microsoft/vscode#138092

  1. Open a relatively large jpg file in the hex editor (I'm viewing https://github.com/corkami/pocs/blob/befb3632214640a4af20be3b463f41e4b82f04f6/images/jpg/20scans.jpg in RemoteHub on desktop)
  2. Scroll down to about midway
  3. Open another editor on top of the hex editor
  4. Switch back to the hex editor and start scrolling while the webview is getting restored
  5. 🐛 hex editor no longer shows contents of the file. Now opening another editor on top of the hex editor and then switching back no longer works to reset the contents of the hex editor--I have to close and reopen it to see the contents of the file again)
hex.mp4
@joyceerhl joyceerhl transferred this issue from microsoft/vscode Nov 30, 2021
connor4312 added a commit that referenced this issue Dec 15, 2021
@connor4312
fix: scrolling with non-zero starts being wrong
d30e5d1 
For #319
@connor4312 connor4312 mentioned this issue Dec 15, 2021
Merged
lramos15 pushed a commit that referenced this issue Dec 16, 2021
@connor4312
Streaming 1 fixes (#325)
94f52a1 
* feat: add large file support

For #313

* fix: shift click in hex editor

For #320

* fix: avoid locking file descriptors of natively opened files

* fix: tweak behavior around dirty file detection

Fixes #321

* feat: allow enter to replace and navigate

For #322

* fix: scrolling with non-zero starts being wrong

For #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@connor4312 @lramos15 @joyceerhl