Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift+click in hex editor does not select range as expected #320

Closed
joyceerhl opened this issue Nov 30, 2021 · 0 comments
Closed

Shift+click in hex editor does not select range as expected #320

joyceerhl opened this issue Nov 30, 2021 · 0 comments
Assignees
@connor4312 @lramos15

Comments

@joyceerhl
Copy link

Testing microsoft/vscode#138092

Not sure which tool I picked this up from, but certainly in the VS Code text editor, shift+click selects a range of text. In the hex editor, shift+click seems to just select the item I last clicked on, plus the item right after it (again, I'm testing against https://github.com/corkami/pocs/blob/befb3632214640a4af20be3b463f41e4b82f04f6/images/jpg/20scans.jpg in RemoteHub desktop):

shiftclick.mp4
connor4312 added a commit that referenced this issue Dec 15, 2021
@connor4312
fix: shift click in hex editor
73c57ce 
For #320
@connor4312 connor4312 mentioned this issue Dec 15, 2021
Merged
lramos15 pushed a commit that referenced this issue Dec 16, 2021
@connor4312
Streaming 1 fixes (#325)
94f52a1 
* feat: add large file support

For #313

* fix: shift click in hex editor

For #320

* fix: avoid locking file descriptors of natively opened files

* fix: tweak behavior around dirty file detection

Fixes #321

* feat: allow enter to replace and navigate

For #322

* fix: scrolling with non-zero starts being wrong

For #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@connor4312 @lramos15 @joyceerhl