Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zh-tw locale #1087

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Add zh-tw locale #1087

merged 2 commits into from
Dec 20, 2021

Conversation

MuTsunTsai
Copy link
Contributor

Traditional Chinese locale.

@ghost
Copy link

ghost commented Nov 23, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@testforstephen testforstephen added this to the 0.38.0 milestone Dec 20, 2021
@testforstephen testforstephen merged commit d9670bc into microsoft:main Dec 20, 2021
@testforstephen
Copy link
Contributor

@MuTsunTsai thanks for your contribution.

@Eskibear
Copy link
Member

Eskibear commented Jan 5, 2022

@testforstephen Do we need to rename previous nls json file from zh to zh-cn?

@testforstephen
Copy link
Contributor

Is there any Best Practice about the nls naming in VS Code extensions?

@Eskibear
Copy link
Member

Eskibear commented Jan 5, 2022

https://stackoverflow.com/questions/56420338/how-to-localise-vscode-extension

looks like CPP extension does a good job. full i18n support.

@testforstephen testforstephen mentioned this pull request Jan 24, 2022
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MuTsunTsai @testforstephen @Eskibear