Cancel cell task when closing related cell doc (#5926)

microsoft · May 19, 2021 · 1f6c401 · 1f6c401
1 parent afddee1
commit 1f6c401
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/news/2 Fixes/5925.md b/news/2 Fixes/5925.md
@@ -0,0 +1 @@
+Resolve issue related to `Interrupt` button vanishing when tabbing across notebooks while a cell is being executed.
diff --git a/src/client/datascience/jupyter/kernels/cellExecution.ts b/src/client/datascience/jupyter/kernels/cellExecution.ts
@@ -150,11 +150,11 @@ export class CellExecution {
                 // No point keeping it alive, just chewing resources.
                 if (e === this.cell.document) {
                     this.request?.dispose(); // NOSONAR
-                }
-                if (this.started && !this._completed) {
-                    this.completedDueToCancellation().catch((ex) =>
-                        traceInfo('Failures when cancelling due to cell removal', ex)
-                    );
+                    if (this.started && !this._completed) {
+                        this.completedDueToCancellation().catch((ex) =>
+                            traceInfo('Failures when cancelling due to cell removal', ex)
+                        );
+                    }
                 }
             },
             this,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Resolve issue related to `Interrupt` button vanishing when tabbing across notebooks while a cell is being executed.