Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel cell task when closing related cell doc #5926

Merged
merged 2 commits into from
May 19, 2021
Merged

Cancel cell task when closing related cell doc #5926

merged 2 commits into from
May 19, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #5925

@DonJayamanne DonJayamanne requested a review from a team as a code owner May 19, 2021 16:07
}
if (this.started && !this._completed) {
this.completedDueToCancellation().catch((ex) =>
if (this.started && !this._completed) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that was a bad one. Nice fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very bad.

@codecov-commenter
Copy link

Codecov Report

Merging #5926 (47d58d0) into main (fdee9dc) will increase coverage by 0%.
The diff coverage is 66%.

@@          Coverage Diff          @@
##            main   #5926   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        404     404           
  Lines      27086   27086           
  Branches    3956    3957    +1     
=====================================
+ Hits       19509   19530   +21     
+ Misses      5945    5902   -43     
- Partials    1632    1654   +22     
Impacted Files Coverage Δ
...lient/datascience/jupyter/kernels/cellExecution.ts 70% <66%> (ø)
...t/datascience/jupyter/jupyterInvalidKernelError.ts 66% <0%> (-34%) ⬇️
src/client/logging/logger.ts 52% <0%> (-18%) ⬇️
src/client/datascience/commands/serverSelector.ts 86% <0%> (-14%) ⬇️
src/client/datascience/kernel-launcher/types.ts 48% <0%> (-8%) ⬇️
src/client/datascience/liveshare/liveshare.ts 75% <0%> (-7%) ⬇️
src/client/activation/activationManager.ts 53% <0%> (-5%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 77% <0%> (-5%) ⬇️
src/client/logging/transports.ts 76% <0%> (-5%) ⬇️
src/client/datascience/datascience.ts 91% <0%> (-5%) ⬇️
... and 34 more

@DonJayamanne DonJayamanne merged commit 1f6c401 into main May 19, 2021
@DonJayamanne DonJayamanne deleted the issue5925 branch May 19, 2021 18:57
@grudloff
Copy link

Hello! This should fix issue #5877?

@DonJayamanne
Copy link
Contributor Author

Oh yes, sorry, I'll update the change log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants