-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel cell task when closing related cell doc #5926
Conversation
} | ||
if (this.started && !this._completed) { | ||
this.completedDueToCancellation().catch((ex) => | ||
if (this.started && !this._completed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that was a bad one. Nice fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, very bad.
Codecov Report
@@ Coverage Diff @@
## main #5926 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 404 404
Lines 27086 27086
Branches 3956 3957 +1
=====================================
+ Hits 19509 19530 +21
+ Misses 5945 5902 -43
- Partials 1632 1654 +22
|
Hello! This should fix issue #5877? |
Oh yes, sorry, I'll update the change log |
For #5925