Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook API #10632

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Update notebook API #10632

merged 4 commits into from
Jun 29, 2022

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner June 29, 2022 18:11
@IanMatthewHuff
Copy link
Member Author

Whoops missed one more change. Updating it now.

@codecov-commenter
Copy link

Codecov Report

Merging #10632 (3387006) into main (34b4614) will increase coverage by 0%.
The diff coverage is 76%.

❗ Current head 3387006 differs from pull request most recent head 141bb78. Consider uploading reports for the commit 141bb78 to get more accurate results

@@          Coverage Diff           @@
##            main   #10632   +/-   ##
======================================
  Coverage     71%      71%           
======================================
  Files        475      475           
  Lines      28050    28050           
  Branches    4707     4706    -1     
======================================
+ Hits       19982    19983    +1     
+ Misses      6197     6190    -7     
- Partials    1871     1877    +6     
Impacted Files Coverage Δ
...ractive-window/interactiveWindowCommandListener.ts 39% <0%> (-1%) ⬇️
src/platform/common/application/types.ts 100% <ø> (ø)
src/notebooks/outputs/errorRendererComms.ts 55% <88%> (+1%) ⬆️
...active-window/debugger/jupyter/debuggingManager.ts 63% <100%> (ø)
src/platform/common/application/notebook.ts 95% <100%> (-1%) ⬇️
src/notebooks/outputs/tracebackFormatter.ts 93% <0%> (-7%) ⬇️
...rc/kernels/debugger/debugLocationTrackerFactory.ts 96% <0%> (-4%) ⬇️
src/platform/common/cancellation.ts 64% <0%> (-4%) ⬇️
...ebooks/controllers/notebookIPyWidgetCoordinator.ts 86% <0%> (-2%) ⬇️
src/kernels/execution/cellExecutionQueue.ts 81% <0%> (-2%) ⬇️
... and 9 more

@IanMatthewHuff IanMatthewHuff merged commit 587cbb0 into main Jun 29, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/updateNotebookAPI branch June 29, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants