-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the finalized notebookEditor API #151661
Comments
I am actually fine in ESLint. The dependency was because of notebook support in LSP and LSP already converted to the final version for the 8.x release of the LSP libs. |
Thank you everyone who's checked off their extension so far! If you have, I plan to remove your extension from the list of |
I'm working on the change for Codespaces and expect it to be in our next extension release (1.10.0) in a few days. I'll reply back once it's on the marketplace. |
We just published GitHub Codespaces 1.10.0 with this change, so you should be able to remove our extension from the list of |
All consumers should now be on the finalized api Fixes microsoft#151661
All consumers should now be on the finalized api Fixes #151661
All consumers should now be on the finalized api Fixes microsoft#151661
The
notebookEditor
has been finalized with VS Code 1.68 🎉 (#149271). If your extension was using the proposal, you should now switch to the finalized version of this API.In the majority of cases, this switch is as simple as:
1.68
vscode.d.ts
notebookEditor
from your list of enabled API proposal.However there are few small bumps to be aware of:
NotebookEditor.document
has been renamedNotebookEditor.notebook
. Please make sure to switch over to the new property name as part of this migrationWe did not finalize the version of
showNotebookDocument
that takes a uri. Instead you can useopenNotebookDocument(uri).then(document => showNotebookDocument(document, options))
Here's a list of all current consumers of the old API proposal:
If you own one of these extensions, please migrate to the finalized notebook editor API. Let me know once the new version of your extension is published and I will remove your extension from the list of api consumers
The text was updated successfully, but these errors were encountered: