Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace URI with URL, latter is more user friendly #12295

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10190

@codecov-commenter
Copy link

Codecov Report

Merging #12295 (e9b0ac6) into main (68fd872) will increase coverage by 0%.
The diff coverage is 62%.

@@          Coverage Diff           @@
##            main   #12295   +/-   ##
======================================
  Coverage     69%      69%           
======================================
  Files        501      501           
  Lines      31909    31909           
  Branches    4999     4999           
======================================
+ Hits       22234    22249   +15     
+ Misses      7793     7781   -12     
+ Partials    1882     1879    -3     
Impacted Files Coverage Δ
src/platform/common/utils/localize.ts 76% <62%> (ø)
...otebooks/controllers/controllerPreferredService.ts 75% <0%> (-1%) ⬇️
...c/platform/interpreter/interpreterPackages.node.ts 73% <0%> (-1%) ⬇️
src/notebooks/controllers/kernelRanking/helpers.ts 60% <0%> (-1%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 73% <0%> (-1%) ⬇️
src/interactive-window/interactiveWindow.ts 69% <0%> (+<1%) ⬆️
src/kernels/errors/kernelErrorHandler.ts 57% <0%> (+1%) ⬆️
.../notebooks/controllers/vscodeNotebookController.ts 85% <0%> (+1%) ⬆️
...rnels/raw/finder/localKernelSpecFinderBase.node.ts 82% <0%> (+1%) ⬆️
...w/finder/interpreterKernelSpecFinderHelper.node.ts 60% <0%> (+1%) ⬆️
... and 2 more

@DonJayamanne DonJayamanne marked this pull request as ready for review December 4, 2022 21:04
@DonJayamanne DonJayamanne merged commit ee6449e into main Dec 4, 2022
@DonJayamanne DonJayamanne deleted the issue10190 branch December 4, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Use URL over URI when connecting to an existing server
3 participants