Avoid validation of Jupyter Server providers #14081
Conversation
| currentServers.forEach(this.createRemoteKernelFinder.bind(this)); | ||
| .then(async (currentServers) => { | ||
| await Promise.all( | ||
| currentServers.map(async (server) => { |
There was a problem hiding this comment.
This was the only place that required validation of the jupyte servers.
All other calls to getAll didn't require a validation.
| return; | ||
| } | ||
| try { | ||
| await this.jupyterPickerRegistration.getJupyterServerUri(item.serverHandle, true); |
There was a problem hiding this comment.
This is only required in one calling place, removed this and move the validation to the calling code.
Thereby removing a cycling reference and more layers.
This also makes listing of Jupyter Server much faster, as we no longer validate each server, which in turn waits for all related extensions to completely activate.
| } | ||
| public async clear(): Promise<void> { | ||
| const all = await this.getAllImpl(false); |
There was a problem hiding this comment.
false is the only value supported now.
| @@ -219,35 +218,30 @@ suite('Server Uri Storage', async () => { | |||
| .sort((a, b) => a.time - b.time) | |||
| .map((a) => { | |||
| return { | |||
| displayName: a.displayName, | |||
There was a problem hiding this comment.
displayName is deprecated
| //Validate each of the servers | ||
| try { | ||
| const info = await this.jupyterPickerRegistration.getJupyterServerUri(serverUri.provider, true); | ||
| this.createRemoteKernelFinder(serverUri.provider, info.displayName); |
There was a problem hiding this comment.
Now that we moved validation all the way up, we can get the display name after we validate.
this makes displayName obsolete in the storage
| @@ -184,6 +184,7 @@ export interface IJupyterServerUriEntry { | |||
| time: number; | |||
| /** | |||
| * An optional display name to show for this server as opposed to just the Uri | |||
| * @deprecated Used only for migration of display names into the User Provided Server list. Else other providers will have the Display Names. | |||
There was a problem hiding this comment.
displayName is deprecated, only used for migration of data from one storage into another
For #13894