Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remote Kernel finder provider #14101

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

DonJayamanne
Copy link
Contributor

For #13894

@DonJayamanne DonJayamanne marked this pull request as ready for review August 11, 2023 03:06
@DonJayamanne DonJayamanne enabled auto-merge (squash) August 11, 2023 03:06
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done, see Line 126, these are registered in the disposable,

Oh I see, I find it much easier to avoid mistakes when the object extends a disposable and then the emitter initialization line can include its lifecycle management:

... = this.register(new EventEmitter())

That's a preference though, looks like you have my problem covered 👌

@DonJayamanne DonJayamanne merged commit e81fc12 into main Aug 11, 2023
30 checks passed
@DonJayamanne DonJayamanne deleted the remoteRemoteKernleFinderProvider branch August 11, 2023 10:49
@DonJayamanne
Copy link
Contributor Author

Oh I see, I find it much easier to avoid mistakes when the object extends a disposable and then the emitter initialization line can include its lifecycle management:

Oh yes, thats a neat solution, yes like that, will use that pattern in the future,
Totally agree about benefit avoiding mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants