fix: tag experimental settings with new system #16116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Oct 10, 2024
| @@ -1802,16 +1803,16 @@ | |||
| "type": "boolean", | |||
| "default": false, | |||
| "description": "Experimental feature to enable execution analysis in notebooks", | |||
| "scope": "application" | |||
| "scope": "application", | |||
There was a problem hiding this comment.
Why are the settings executionAnalysis.enabled and interactive.notebookRepl using different tags.
One has onExp and other doesn't have it
There was a problem hiding this comment.
onExP means the setting could be assigned to an A/B experiment.
If that's not the intent behind the setting, I could remove that tag from the setting.
There was a problem hiding this comment.
is there an A/B experiment for (or planned for) executionAnalysis.enabled? that's what that tag is for.
Eventually we'll get an experiment for the notebook REPL.
DonJayamanne
approved these changes
Oct 11, 2024
amunger
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm retagging some Jupyter extension settings as part of the experimental -> onExP rename where: