Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tag experimental settings with new system #16116

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: tag experimental settings with new system #16116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
420f521
fix: tag experimental settings with new system
rzhao271 Oct 10, 2024
72d1dee
Consider enableKernelCompletions as stable
rzhao271 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,7 +1708,7 @@
"default": false,
"description": "%jupyter.configuration.jupyter.interactiveWindowNotebookRepl.description%",
"tags": [
"experimental"
"experimental", "onExP"
]
},
"jupyter.interactiveWindow.textEditor.cellFolding": {
Expand Down Expand Up @@ -1802,15 +1802,18 @@
"type": "boolean",
"default": false,
"description": "Experimental feature to enable execution analysis in notebooks",
"scope": "application"
"scope": "application",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the settings executionAnalysis.enabled and interactive.notebookRepl using different tags.
One has onExp and other doesn't have it

Copy link
Contributor Author

@rzhao271 rzhao271 Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onExP means the setting could be assigned to an A/B experiment.
If that's not the intent behind the setting, I could remove that tag from the setting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an A/B experiment for (or planned for) executionAnalysis.enabled? that's what that tag is for.
Eventually we'll get an experiment for the notebook REPL.

"tags": [
"experimental"
]
},
"jupyter.enableKernelCompletions": {
"type": "boolean",
"default": true,
"markdownDescription": "%jupyter.configuration.jupyter.enableKernelCompletions.markdownDescription%",
"scope": "application",
"tags": [
"experimental"
"onExP"
DonJayamanne marked this conversation as resolved.
Show resolved Hide resolved
]
},
"jupyter.formatStackTraces": {
Expand Down
Loading