Intercept stopped event when auto-stepping through code in other files/cells #7248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
force-pushed
the
roblou/interceptStopped
branch
from
2edb532 to
bb6159a
Compare
| @@ -236,8 +261,15 @@ export class KernelDebugAdapter implements DebugAdapter, IKernelDebugAdapter, ID | |||
| }); | |||
| } | |||
|
|
|||
| private stackTrace(): void { | |||
| void this.session.customRequest('stackTrace', { threadId: this.threadId }); | |||
| private stackTrace(args?: { | |||
There was a problem hiding this comment.
Please can we rename this to getStacktrace, I saw this earlier and it tripped me, didn't know if it was a Method that got data or a funky method (like a property) that just returned existing existing data or an existing promise
DonJayamanne
approved these changes
Aug 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #7248 +/- ##
======================================
- Coverage 64% 62% -3%
======================================
Files 360 360
Lines 22518 22529 +11
Branches 3398 3400 +2
======================================
- Hits 14612 14048 -564
- Misses 6614 7306 +692
+ Partials 1292 1175 -117
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7218
Fixes #6856
Has a news entry file (remember to thank yourself!).Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).