Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug cleanup in Run by Line #7218

Closed
8 tasks done
Tracked by #5607
DavidKutu opened this issue Aug 20, 2021 · 1 comment
Closed
8 tasks done
Tracked by #5607

Bug cleanup in Run by Line #7218

DavidKutu opened this issue Aug 20, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line

Comments

@DavidKutu
Copy link

DavidKutu commented Aug 20, 2021

High priority

  • context keys are sometimes stuck in the "running" state
    • Seems that we run the cell but don't hit the breakpoint, and don't reset the keys. See logs below
  • RBL button doesn't show up sometimes
  • Sometimes I am blocked by an error with starting the kernel. I get a modal error about a missing debug adapter, and an infinite "Starting run by line" notification
  • When stepping over a call to another file, the other file is still opened
    • don't send stopped events to vscode when we're outside the notebook. Check stacktrace request to see if we get response right away.

Lower priority

  • show the "starting run by line" notification only the first time
  • set global context keys based on active editor, so I can run two RBL sessions in two notebooks
  • Context keys are reset when any other debug session ends
    • debug.onDidTerminateDebugSession, check for our own sessions
  • setting for optionally showing variable explorer
@DavidKutu DavidKutu added the bug Issue identified by VS Code Team member as probable bug label Aug 20, 2021
@roblourens
Copy link
Member

worked.log
didntwork.log

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line
Projects
None yet
Development

No branches or pull requests

3 participants