Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting for bringing up the variable view #7314

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

DavidKutu
Copy link

For part of #7218

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner August 26, 2021 23:29
@DavidKutu DavidKutu requested a review from roblourens August 26, 2021 23:29
@codecov-commenter
Copy link

Codecov Report

Merging #7314 (302b645) into main (c2b6335) will increase coverage by 3%.
The diff coverage is 44%.

@@          Coverage Diff           @@
##            main   #7314    +/-   ##
======================================
+ Coverage     62%     65%    +3%     
======================================
  Files        360     360            
  Lines      22539   22546     +7     
  Branches    3404    3409     +5     
======================================
+ Hits       14080   14765   +685     
+ Misses      7284    6478   -806     
- Partials    1175    1303   +128     
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø)
src/client/debugger/jupyter/kernelDebugAdapter.ts 4% <0%> (-1%) ⬇️
src/client/common/configSettings.ts 85% <100%> (+<1%) ⬆️
src/client/debugger/jupyter/debuggingManager.ts 24% <100%> (+2%) ⬆️
...atascience/jupyter/kernels/jupyterKernelService.ts 77% <0%> (-5%) ⬇️
src/client/common/cancellation.ts 72% <0%> (-4%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 53% <0%> (-2%) ⬇️
...ient/datascience/kernel-launcher/kernelLauncher.ts 90% <0%> (-2%) ⬇️
.../localPythonAndRelatedNonPythonKernelSpecFinder.ts 79% <0%> (-1%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 68% <0%> (-1%) ⬇️
... and 49 more

@DavidKutu DavidKutu merged commit c2263dc into main Aug 26, 2021
@DavidKutu DavidKutu deleted the david/varViewSetting branch August 26, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants