Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8933
The INotebookProvider will remain for now, this is just step 1 of refactoring to remove/refactor some of the old code related to live share.
Note: INotebook had two properties & one of the was IJupyterSesion & the other connection, & connection was never used, hence INotebook interface was completely unnecessary, we could have just one property session or remote it all together - went with the latter.
I don't want to rename
INotebookProvider
toISessionProvider
as we already have a interface namedISessionManager
& both have create functions.The Notebook provider does a few things that we an split, e.g. starting of Jupyter for local non-raw cases, or it can be done by other means, either way, that can be done seprately (and a few more changes to simplify things).
TLDR - this only focuses on removing INotebook