Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connection out of execution #9918

Merged
merged 4 commits into from
May 7, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #8933

Basically the long term plan is to remove the JupyterExecution.
Creating connection information and validating connections to remote jupyter servers isn't a responsibility of the JupyterExecution. the class is kinda overloaded.

Moved connection related stuff into JupyterConnection class.

@DonJayamanne DonJayamanne requested a review from a team as a code owner May 6, 2022 01:37
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #9918 (02ab9ba) into main (3ba1e47) will decrease coverage by 31%.
The diff coverage is n/a.

❗ Current head 02ab9ba differs from pull request most recent head 662eae7. Consider uploading reports for the commit 662eae7 to get more accurate results

@@          Coverage Diff           @@
##           main   #9918     +/-   ##
======================================
- Coverage    63%     32%    -32%     
======================================
  Files       203     203             
  Lines      9834    9834             
  Branches   1566    1566             
======================================
- Hits       6249    3172   -3077     
- Misses     3083    6503   +3420     
+ Partials    502     159    -343     
Impacted Files Coverage Δ
src/platform/debugger/debugLocationTracker.node.ts 3% <0%> (-91%) ⬇️
src/platform/common/contextKey.ts 11% <0%> (-89%) ⬇️
src/platform/common/process/pythonProcess.node.ts 10% <0%> (-87%) ⬇️
src/platform/common/utils/text.node.ts 11% <0%> (-86%) ⬇️
src/platform/common/refBool.node.ts 16% <0%> (-84%) ⬇️
src/platform/common/net/fileDownloader.node.ts 21% <0%> (-79%) ⬇️
src/platform/common/experiments/telemetry.node.ts 22% <0%> (-78%) ⬇️
src/platform/progress/progressReporter.node.ts 16% <0%> (-76%) ⬇️
src/platform/common/application/documentManager.ts 8% <0%> (-75%) ⬇️
src/platform/export/exportFileOpener.node.ts 26% <0%> (-74%) ⬇️
... and 132 more

@DonJayamanne DonJayamanne merged commit 1ee455c into main May 7, 2022
@DonJayamanne DonJayamanne deleted the refactorConnectionExecution branch May 7, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review architecture and design of Jupyter extension
3 participants