Fix copy behavior for sorted and/or filtered grid

[cssuh]

Correctly copies the grid values for a grid that has been sorted and/or filtered.

Before, we were using a getRows call to STS which fetches the data based on the initial query. Once we sort or filter any data in the grid (which triggers isDataInMemory flag = true), we should use the dataProvider to tell us what data the user wants to copy, since it knows the context of the sort or filter states.

Fixes #18516
Fixes #18620

[github-actions]

PR Changes

Category	Main Branch	PR Branch	Difference
Code Coverage	50.40%	50.54%	$${\color{lightgreen} .14\% }$$
VSIX Size	12969 KB	12143 KB	$${\color{lightgreen} -826 KB \space (-6\%) }$$
Webview Bundle Size	3188 KB	3176 KB	$${\color{lightgreen} -12 KB \space (0\%) }$$

[caohai]

Can you explain the following two things at a high level in the PR description?

1. Root cause of the issues
2. The fix you implemented in this PR

[Benjin]

Looks like this PR only addresses copying, but the same problem occurs for all copy/save targets. Maybe we need a more fundamental fix here.

Unfortunately, it seems that ADS has the same issue, where the "save" actions don't respect sorting and filtering, probably because they occur on the backend. Perhaps we need a UX solution in the meantime (e.g. "copy selection" where we can support that and "save all as .xyz" where we can't)

[Benjin]

A selection potentially spans multiple rows, right? So will this map have multiple rowId entries pointing to the same ISlickRange?

[cssuh]

Yes that's correct

[caohai]

I gave the PR branch a quick test and can confirm copying is fixed with sorted/filtered grid.

One more question: I noticed the filter state is kept during context switch but the sorting state is not, is this intentional or do we want to fix it later?

Looks like this PR only addresses copying, but the same problem occurs for all copy/save targets. Maybe we need a more fundamental fix here.

Can confirm save is still broken, we might want to create a seperate issue for tracking.

[cssuh]

I gave the PR branch a quick test and can confirm copying is fixed with sorted/filtered grid.

One more question: I noticed the filter state is kept during context switch but the sorting state is not, is this intentional or do we want to fix it later?

Looks like this PR only addresses copying, but the same problem occurs for all copy/save targets. Maybe we need a more fundamental fix here.

Can confirm save is still broken, we might want to create a seperate issue for tracking.

Yeah, we want to keep the sort state as well, I will add an issue to track this as well as an issue for the save targets