[Port Request] Fix copy behavior for sorted and/or filtered grid (#18695) #18729
+328
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix copy behavior for sorted grid * cleanup * refactor pr comments * assign copy string * refactor * add comments * remove console.log
cssuh
requested review from
kburtram,
aasimkhan30,
caohai,
laurennat,
lewis-sanchez and
Benjin
as code owners
Benjin
approved these changes
Feb 20, 2025
kburtram
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes copy behavior by using the grid's built in Data provider if the grid is sorted or filtered (isDataInMemory = true), instead of making a getRows call to STS which would return the original grid data (before filtering/sorting is applied).
Ports #18695
Fixes #18516
Fixes #18620
This is a re-issue of #18719 which ported to the wrong release branch.