-
Notifications
You must be signed in to change notification settings - Fork 563
Fixes issue where there's no way to sign into additional tenants for an Azure account #20757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
commented
Dec 9, 2025
extensions/mssql/src/connectionconfig/connectionDialogWebviewController.ts
Show resolved
Hide resolved
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20757 +/- ##
==========================================
+ Coverage 65.89% 65.93% +0.03%
==========================================
Files 210 210
Lines 19728 19777 +49
Branches 2535 2539 +4
==========================================
+ Hits 12999 13039 +40
- Misses 6638 6647 +9
Partials 91 91
🚀 New features to boost your workflow:
|
aasimkhan30
approved these changes
Dec 10, 2025
Benjin
added a commit
that referenced
this pull request
Dec 10, 2025
…an Azure account (#20757) * checkpoint with banner * adding detection of and ability to sign into not-signed-in tenants * loc * comments * adding/updating tests * linter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
Addresses #19516
Checks if any accounts have tenants that haven't granted access to MSSQL, and adds an extra link/button if so. Users can hover over the tenant link to see which tenants are signed into for which accounts.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines