Skip to content

Conversation

@Benjin
Copy link
Contributor

@Benjin Benjin commented Dec 10, 2025

Original PR: #20757
Bug: #19516

…an Azure account (#20757)

* checkpoint with banner

* adding detection of and ability to sign into not-signed-in tenants

* loc

* comments

* adding/updating tests

* linter errors
@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5261 KB 5262 KB ⚪ 1 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.93%. Comparing base (c6bdb75) to head (bb07ca3).

Files with missing lines Patch % Lines
...nectionconfig/connectionDialogWebviewController.ts 78.26% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/1.38   #20772      +/-   ##
================================================
+ Coverage         65.89%   65.93%   +0.03%     
================================================
  Files               210      210              
  Lines             19728    19777      +49     
  Branches           2535     2539       +4     
================================================
+ Hits              12999    13039      +40     
- Misses             6638     6647       +9     
  Partials             91       91              
Files with missing lines Coverage Δ
...ensions/mssql/src/connectionconfig/azureHelpers.ts 66.32% <100.00%> (+0.17%) ⬆️
...ons/mssql/src/sharedInterfaces/connectionDialog.ts 97.82% <100.00%> (+0.09%) ⬆️
...nectionconfig/connectionDialogWebviewController.ts 59.11% <78.26%> (+1.25%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin Benjin merged commit 488d319 into release/1.38 Dec 11, 2025
3 checks passed
@Benjin Benjin deleted the port/benjin/20757 branch December 11, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants