French language translation #1394

PixiBixi · 2018-04-13T16:07:06Z

Add french language to the vscode-python plugin :)

msftclas · 2018-04-13T16:07:17Z

All CLA requirements met.

codecov · 2018-04-13T17:21:20Z

Codecov Report

Merging #1394 into master will increase coverage by 3.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   71.01%   74.56%   +3.55%     
==========================================
  Files         269      285      +16     
  Lines       12416    13359     +943     
  Branches     2199     2390     +191     
==========================================
+ Hits         8817     9961    +1144     
+ Misses       3461     3265     -196     
+ Partials      138      133       -5

Impacted Files	Coverage Δ
src/client/common/platform/pathUtils.ts	`80% <0%> (-20%)`	⬇️
src/client/unittests/main.ts	`36.32% <0%> (-14.44%)`	⬇️
...lient/debugger/configProviders/pythonV2Provider.ts	`87.34% <0%> (-12.66%)`	⬇️
src/client/common/platform/fileSystem.ts	`67.53% <0%> (-11.64%)`	⬇️
src/client/common/logger.ts	`42.1% <0%> (-11.23%)`	⬇️
src/client/interpreter/virtualEnvs/index.ts	`89.36% <0%> (-10.64%)`	⬇️
...ent/interpreter/locators/services/pipEnvService.ts	`84.61% <0%> (-10.13%)`	⬇️
src/client/interpreter/helpers.ts	`88.37% <0%> (-7.09%)`	⬇️
src/client/common/terminal/service.ts	`93.75% <0%> (-6.25%)`	⬇️
src/client/activation/classic.ts	`91.83% <0%> (-5.67%)`	⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd5095...869d9ef. Read the comment docs.

brettcannon · 2018-04-16T22:10:54Z

Thanks for the PR! Could you change the README and add a news entry file? (See #1152 for examples.)

I will also ask on Twitter for a review since none of our team members are native French speakers. 😄

browniebroke · 2018-04-16T22:40:32Z

package.nls.fr.json

+ "python.command.python.sortImports.title": "Trier les imports",
+ "python.command.python.startREPL.title": "Démarrer REPL",
+ "python.command.python.createTerminal.title": "Créer un Terminal",
+ "python.command.python.buildWorkspaceSymbols.title": "Build Workspace Symbols",


Construire les symboles de l'espace de travail ?

browniebroke · 2018-04-16T22:41:27Z

package.nls.fr.json

+ "python.command.python.execInTerminal.title": "Exécuter le script Python dans un Terminal",
+ "python.command.python.setInterpreter.title": "Selectionner l'interpreteur",
+ "python.command.python.updateSparkLibrary.title": "Mettre à jour les librairies de l'espace de travail pySpark",
+ "python.command.python.refactorExtractVariable.title": "Extraire la ariable",


Typo "variable"

browniebroke · 2018-04-16T22:47:03Z

package.nls.fr.json

+ "python.snippet.launch.flask.label": "Python: Flask (0.11.x ou supérieur)",
+ "python.snippet.launch.flask.description": "Debugger une Application Flask",
+ "python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x ou antérieur)",
+ "python.snippet.launch.flaskOld.description": "Debug une application Flask de l'ancien style",


I think the French version is written "déboguer"

http://www.larousse.fr/dictionnaires/francais/d%C3%A9boguer/21835

yes, and débugger is also commonly used & accepted

PixiBixi · 2018-04-16T23:08:37Z

Ahah @brettcannon its fine, i'll custom the README file :D

Thanks @browniebroke i'll fix it ASAP. And indeed, we can say déboguer in "pure" french, but tbh, everyone understand if i put "Debug" or "Debugger", but i'll fix it

tarekziade

LGTM besides uppercases and a choice to make on how to write "to debug")

tarekziade · 2018-04-17T07:08:21Z

package.nls.fr.json

@@ -0,0 +1,49 @@
+{
+ "python.command.python.sortImports.title": "Trier les imports",
+ "python.command.python.startREPL.title": "Démarrer REPL",


Démarrer la console interactive

(don't put uppercase words in sentences in French)

tarekziade · 2018-04-17T07:08:35Z

package.nls.fr.json

+{
+ "python.command.python.sortImports.title": "Trier les imports",
+ "python.command.python.startREPL.title": "Démarrer REPL",
+ "python.command.python.createTerminal.title": "Créer un Terminal",


Créer un terminal

tarekziade · 2018-04-17T07:10:07Z

package.nls.fr.json

+ "python.command.python.createTerminal.title": "Créer un Terminal",
+ "python.command.python.buildWorkspaceSymbols.title": "Build Workspace Symbols",
+ "python.command.python.runtests.title": "Exécuter tous les tests unitaires",
+ "python.command.python.debugtests.title": "Debugger tous les tests unitaires",


Déboguer tous les tests unitaires

(notice that Débugger is also accepted)

tarekziade · 2018-04-17T07:10:20Z

package.nls.fr.json

+ "python.command.python.buildWorkspaceSymbols.title": "Build Workspace Symbols",
+ "python.command.python.runtests.title": "Exécuter tous les tests unitaires",
+ "python.command.python.debugtests.title": "Debugger tous les tests unitaires",
+ "python.command.python.execInTerminal.title": "Exécuter le script Python dans un Terminal",


s/Terminal/terminal

tarekziade · 2018-04-17T07:10:44Z

package.nls.fr.json

+ "python.command.python.runtests.title": "Exécuter tous les tests unitaires",
+ "python.command.python.debugtests.title": "Debugger tous les tests unitaires",
+ "python.command.python.execInTerminal.title": "Exécuter le script Python dans un Terminal",
+ "python.command.python.setInterpreter.title": "Selectionner l'interpreteur",


Sélectionner l'interpréteur

tarekziade · 2018-04-17T07:15:04Z

package.nls.fr.json

+ "python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x ou antérieur)",
+ "python.snippet.launch.flaskOld.description": "Debug une application Flask de l'ancien style",
+ "python.snippet.launch.pyramid.label": "Python: application Pyramid",
+ "python.snippet.launch.pyramid.description": "Debugger une application Pyramid",


Débugger or Déboguer

tarekziade · 2018-04-17T07:15:20Z

package.nls.fr.json

+ "python.snippet.launch.pyramid.label": "Python: application Pyramid",
+ "python.snippet.launch.pyramid.description": "Debugger une application Pyramid",
+ "python.snippet.launch.watson.label": "Python: Application Watson",
+ "python.snippet.launch.watson.description": "Debugger une Application Watson",


Débugger une application Watson

tarekziade · 2018-04-17T07:17:12Z

package.nls.fr.json

+ "python.snippet.launch.watson.label": "Python: Application Watson",
+ "python.snippet.launch.watson.description": "Debugger une Application Watson",
+ "python.snippet.launch.attach.label": "Python: Attacher",
+ "python.snippet.launch.attach.description": "Attacher le debugger pour un debugging distant",


débogueur or débugueur (yeah I know, the second one is weird, but it's the French adaptation of the English word - if you picked Débugger earlier, use that one)

tarekziade · 2018-04-17T07:17:21Z

package.nls.fr.json

+ "python.snippet.launch.attach.label": "Python: Attacher",
+ "python.snippet.launch.attach.description": "Attacher le debugger pour un debugging distant",
+ "python.snippet.launch.scrapy.label": "Python: Scrapy",
+ "python.snippet.launch.scrapy.description": "Scrapy avec un Terminal intégré"


tarekziade · 2018-04-17T07:17:32Z

package.nls.fr.json

+ "python.snippet.launch.attach.description": "Attacher le debugger pour un debugging distant",
+ "python.snippet.launch.scrapy.label": "Python: Scrapy",
+ "python.snippet.launch.scrapy.description": "Scrapy avec un Terminal intégré"
+}


no new line at EOF

Thats kinda better, thanks for your fix :)

brettcannon · 2018-04-19T23:46:36Z

@PixiBixi FYI we go into code freeze for the next release on Monday, April 30, so if we can get the required changes in by then we can include this in the April release. 😄

brettcannon · 2018-04-30T18:38:56Z

This has missed the April release. If @PixiBixi doesn't have time to address comments sometime this week then we will be open to someone forking this PR and making the appropriate changes along with listing @PixiBixi as a co-author on the PR.

brettcannon · 2018-05-28T19:27:38Z

Since we aren't getting follow-up from @PixiBixi , anyone can feel free to fork this and submit a new PR with a French translation.

PixiBixi · 2018-05-28T19:29:06Z

Ohhh i had absolutely forget this PR @brettcannon, sorry ! I'll try to fix it in the week :)

brettcannon · 2018-05-29T17:01:00Z

@PixiBixi thanks!

n6g7 · 2018-06-09T22:58:30Z

@PixiBixi let me know if you need help, I can pick this up if need be.

smortaz · 2018-06-09T23:16:14Z

Hugues might be interested in reviewing.

…

On Sat, Jun 9, 2018 at 3:58 PM Nathan Gaberel ***@***.***> wrote: @PixiBixi <https://github.com/PixiBixi> let me know if you need help, I can pick this up if need be. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1394 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtUVBN8nAVWXzwijf2Qkdt9262Ki_8Bks5t7FMXgaJpZM4TTtH8> .

brettcannon · 2018-06-11T18:49:03Z

@huguesv feel free to provide feedback if you want (or a fr-ca translation 😁 ).

browniebroke · 2018-06-14T08:43:43Z

package.nls.fr.json

+ "python.snippet.launch.flask.label": "Python: Flask (0.11.x ou supérieur)",
+ "python.snippet.launch.flask.description": "Débugger une application Flask",
+ "python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x ou antérieur)",
+ "python.snippet.launch.flaskOld.description": "Debug une application Flask de l'ancien style",


One last thing, I think the "Debug" here should be changed to "Débugger" to be consistent with the other wording.

"de l'ancien style" is very vague, I think we should use "version" instead. Maybe something like "Débugger une application Flask (ancienne version)"?

Why not follow the label description:
Débugger une application Flask (0.10.x ou antérieur)

n6g7 · 2018-06-14T10:43:48Z

package.nls.fr.json

+ "python.snippet.launch.flask.label": "Python: Flask (0.11.x ou supérieur)",
+ "python.snippet.launch.flask.description": "Débugger une application Flask",
+ "python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x ou antérieur)",
+ "python.snippet.launch.flaskOld.description": "Debug une application Flask de l'ancien style",


"de l'ancien style" is very vague, I think we should use "version" instead. Maybe something like "Débugger une application Flask (ancienne version)"?

n6g7 · 2018-06-14T10:44:50Z

package.nls.fr.json

+ "python.command.python.runLinting.title": "Exécuter le linting",
+ "python.snippet.launch.standard.label": "Python: Fichier actuel",
+ "python.snippet.launch.standard.description": "Débugger un programme Python avec la sortie standard",
+ "python.snippet.launch.pyspark.label": "Python: PySpark",


There's a space before the colon in French: "Python : PySpark". Same for all other labels below.

n6g7 · 2018-06-14T10:47:18Z

package.nls.fr.json

+ "python.snippet.launch.watson.label": "Python: Application Watson",
+ "python.snippet.launch.watson.description": "Débugger une Application Watson",
+ "python.snippet.launch.attach.label": "Python: Attacher",
+ "python.snippet.launch.attach.description": "Attacher le débugger pour un debugging distant",


The noun "débugger" (debugger) is spelt exactly the same as the verb "débugger" (to debug), is there a different spelling we could use to make it clearer?

VSCode itself actually uses "déboguer" and "débogueur", perhaps we should use that instead for consistence?

I agree for consistency, if general VSCode is already doing "Déboguer/débogage/débogueurs", we should use it here as well.

brettcannon · 2018-06-14T19:43:07Z

I have gone ahead and merged this with the latest round of comments. If there is anything people want changed before the next release (scheduled for Monday), please send a PR. I will send out a separate PR to add the translation to the README and the news entry.

Thanks to everyone who helped with this!

[ADD] French Language

9a257b6

brettcannon changed the title ~~[ADD] French Language~~ French language translation Apr 16, 2018

browniebroke reviewed Apr 16, 2018

View reviewed changes

tarekziade reviewed Apr 17, 2018

View reviewed changes

brettcannon added 2 commits June 13, 2018 17:44

Address feedback

f04417a

Address more feedback

be533b4

brettcannon mentioned this pull request Jun 14, 2018

Translate the extension to French #1959

Closed

browniebroke reviewed Jun 14, 2018

View reviewed changes

n6g7 reviewed Jun 14, 2018

View reviewed changes

More reviewer feedback

869d9ef

brettcannon merged commit 5949f74 into microsoft:master Jun 14, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

French language translation #1394

French language translation #1394

Conversation

PixiBixi commented Apr 13, 2018

msftclas commented Apr 13, 2018 • edited Loading

codecov bot commented Apr 13, 2018 • edited Loading

Codecov Report

brettcannon commented Apr 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PixiBixi commented Apr 16, 2018

tarekziade left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brettcannon commented Apr 19, 2018

brettcannon commented Apr 30, 2018

brettcannon commented May 28, 2018

PixiBixi commented May 28, 2018

brettcannon commented May 29, 2018

n6g7 commented Jun 9, 2018

smortaz commented Jun 9, 2018 via email

brettcannon commented Jun 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brettcannon commented Jun 14, 2018

msftclas commented Apr 13, 2018 •

edited

Loading

codecov bot commented Apr 13, 2018 •

edited

Loading