Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove old code for folder support in interpreter path setting" #22638

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Dec 12, 2023

Reverts #22413 #22618

Turns out we still need this code for old deprecated APIs that we expose, one of which is used in testing.

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Dec 12, 2023
@karrtikr karrtikr enabled auto-merge (squash) December 12, 2023 23:20
@karrtikr karrtikr merged commit 13047b8 into main Dec 12, 2023
55 checks passed
@karrtikr karrtikr deleted the revert-22413-kartik/compact-vulture branch December 12, 2023 23:23
karrtikr pushed a commit that referenced this pull request Dec 13, 2023
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Dec 13, 2023
…g" (microsoft#22638)

Reverts microsoft#22413
microsoft#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Dec 13, 2023
karthiknadig pushed a commit that referenced this pull request Dec 13, 2023
…g" (#22638)

Reverts #22413
#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
karthiknadig pushed a commit that referenced this pull request Dec 13, 2023
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…1 from upstream

Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1

Merge vscode-python 2023.22.1 from upstream
--------------------
Commit message for posit-dev/positron-python@e0d7a6a:

Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e'

--------------------
Commit message for posit-dev/positron-python@c26d5e7:

update version for point release 2023.22.1

--------------------
Commit message for posit-dev/positron-python@c3364b5:

More fixes to pre-release (posit-dev/positron-python#22641)

Further followup to
microsoft/vscode-python#22640
--------------------
Commit message for posit-dev/positron-python@0a570b5:

More fixes to pre-release (posit-dev/positron-python#22640)

Following up to microsoft/vscode-python#22638
--------------------
Commit message for posit-dev/positron-python@a712e12:

Fix localization failure for pre-release (posit-dev/positron-python#22639)

Fixes pre-release, dynamic strings are not supported by localization.
--------------------
Commit message for posit-dev/positron-python@d31b870:

Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638)

Reverts microsoft/vscode-python#22413
microsoft/vscode-python#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
--------------------
Commit message for posit-dev/positron-python@780870a:

finalized-release-2023.22 (posit-dev/positron-python#22608)

update to final release number for 2023.22

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…1 from upstream

Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1

Merge vscode-python 2023.22.1 from upstream
--------------------
Commit message for posit-dev/positron-python@e0d7a6a:

Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e'

--------------------
Commit message for posit-dev/positron-python@c26d5e7:

update version for point release 2023.22.1

--------------------
Commit message for posit-dev/positron-python@c3364b5:

More fixes to pre-release (posit-dev/positron-python#22641)

Further followup to
microsoft/vscode-python#22640
--------------------
Commit message for posit-dev/positron-python@0a570b5:

More fixes to pre-release (posit-dev/positron-python#22640)

Following up to microsoft/vscode-python#22638
--------------------
Commit message for posit-dev/positron-python@a712e12:

Fix localization failure for pre-release (posit-dev/positron-python#22639)

Fixes pre-release, dynamic strings are not supported by localization.
--------------------
Commit message for posit-dev/positron-python@d31b870:

Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638)

Reverts microsoft/vscode-python#22413
microsoft/vscode-python#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
--------------------
Commit message for posit-dev/positron-python@780870a:

finalized-release-2023.22 (posit-dev/positron-python#22608)

update to final release number for 2023.22

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants