Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front end and Zed support for new environment pane messages #297

Merged
merged 9 commits into from
Mar 17, 2023
Merged

Front end and Zed support for new environment pane messages #297

merged 9 commits into from
Mar 17, 2023

Conversation

jmcphers
Copy link
Collaborator

This change does four things:

  1. Adds client (Positron) side typing and support for new types and messages used by the nascent Environment pane protocol
  2. Adds two new commands to Zed that update and remove variables from the environment (update X and rm X)
  3. Makes the Environment UI respond correctly to the new message types
  4. Adds a wrapper around the Environment server communicator/client instance that emits strongly typed messages

@softwarenerd softwarenerd merged commit d8773da into main Mar 17, 2023
@wesm wesm deleted the feature/env-pane-messages branch March 15, 2024 18:26
wesm pushed a commit that referenced this pull request Mar 28, 2024
@eleanorjboyd @seeM
Merged PR posit-dev/positron-python#297: Merge vscode-python 2023.22.…
bbe9ae5 
…1 from upstream

Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1

Merge vscode-python 2023.22.1 from upstream
--------------------
Commit message for posit-dev/positron-python@e0d7a6a:

Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e'

--------------------
Commit message for posit-dev/positron-python@c26d5e7:

update version for point release 2023.22.1

--------------------
Commit message for posit-dev/positron-python@c3364b5:

More fixes to pre-release (posit-dev/positron-python#22641)

Further followup to
microsoft/vscode-python#22640
--------------------
Commit message for posit-dev/positron-python@0a570b5:

More fixes to pre-release (posit-dev/positron-python#22640)

Following up to microsoft/vscode-python#22638
--------------------
Commit message for posit-dev/positron-python@a712e12:

Fix localization failure for pre-release (posit-dev/positron-python#22639)

Fixes pre-release, dynamic strings are not supported by localization.
--------------------
Commit message for posit-dev/positron-python@d31b870:

Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638)

Reverts microsoft/vscode-python#22413
microsoft/vscode-python#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
--------------------
Commit message for posit-dev/positron-python@780870a:

finalized-release-2023.22 (posit-dev/positron-python#22608)

update to final release number for 2023.22

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
wesm pushed a commit that referenced this pull request Mar 28, 2024
@eleanorjboyd @seeM @wesm
Merged PR posit-dev/positron-python#297: Merge vscode-python 2023.22.…
c881336 
…1 from upstream

Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1

Merge vscode-python 2023.22.1 from upstream
--------------------
Commit message for posit-dev/positron-python@e0d7a6a:

Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e'

--------------------
Commit message for posit-dev/positron-python@c26d5e7:

update version for point release 2023.22.1

--------------------
Commit message for posit-dev/positron-python@c3364b5:

More fixes to pre-release (posit-dev/positron-python#22641)

Further followup to
microsoft/vscode-python#22640
--------------------
Commit message for posit-dev/positron-python@0a570b5:

More fixes to pre-release (posit-dev/positron-python#22640)

Following up to microsoft/vscode-python#22638
--------------------
Commit message for posit-dev/positron-python@a712e12:

Fix localization failure for pre-release (posit-dev/positron-python#22639)

Fixes pre-release, dynamic strings are not supported by localization.
--------------------
Commit message for posit-dev/positron-python@d31b870:

Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638)

Reverts microsoft/vscode-python#22413
microsoft/vscode-python#22618

Turns out we still need this code for old deprecated APIs that we
expose, one of which is used in testing.
--------------------
Commit message for posit-dev/positron-python@780870a:

finalized-release-2023.22 (posit-dev/positron-python#22608)

update to final release number for 2023.22

Lead-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softwarenerd softwarenerd Awaiting requested review from softwarenerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcphers @softwarenerd