Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting linting.lintOnTextChange as it was never implemented #315

Merged
merged 34 commits into from
Nov 28, 2017

Conversation

DonJayamanne
Copy link

Fixes #313
The setting linting.lintOnTextChange is deprecated as it was never implemented.

octref and others added 30 commits November 3, 2017 13:11
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master:
  Fix typo in README.md (#252)
  Disable linter without workspaces (#241)
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
* upstream/master:
  Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
  Fixes #22 to Detect anaconda from known locations  (#221)
  Use workspaceFolder token instead of workspaceRoot (#267)
  Fix registry lookup response (#224)
  Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master:
  Fix debugging tests (#304)
* upstream/master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* upstream/master:
  Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 28, 2017
@DonJayamanne
Copy link
Author

@brettcannon found out that the setting did not do anything simply because the code was not using it at all. I.e. it was never implemented.

@DonJayamanne
Copy link
Author

@brettcannon FYI - one change I introduced is, the deprecation notice is displayed only if the deprecated settings are turned on. There's no point displaying the deprecation notice if the formatOnSave is turned off.

@DonJayamanne DonJayamanne merged commit e2218b1 into microsoft:master Nov 28, 2017
@DonJayamanne DonJayamanne deleted the removeLintingOnTextChange branch December 12, 2017 21:22
DonJayamanne added a commit that referenced this pull request Dec 14, 2017
* upstream/master:
  Remove setting linting.lintOnTextChange as it was never implemented (#315)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting 'linting.lintOnTextChange' has been deprecated
3 participants