Change os.arch() to npm arch to fix wrong arch detection.
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR, @MichaelSuen-thePointer ! I'm not sure if we will get this before January, but we will review it at some point. |
DonJayamanne
approved these changes
Dec 15, 2017
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2018
* upstream/master: Make use of new execution layer instead of spawning processes (#425) Use localhost instead of 0.0.0.0 for all local socket servers (#417) Provide full signature help with highlighted parameter (#416) Change `os.arch()` to `npm` `arch` to fix wrong arch detection. (#419) Document our Russian support (#424) Bump the version number to the next release as an alpha (#422) Russian translation (#411) Speed up virtual environment detection in workspace (#405)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #414