Use localhost instead of 0.0.0.0 for all local socket servers #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive of 0.7.0
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
* upstream/master: Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
Fixes #22 to Detect anaconda from known locations (#221)
Use workspaceFolder token instead of workspaceRoot (#267)
Fix registry lookup response (#224)
Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master: Fix debugging tests (#304)
* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master: Fix travis build error (#326)
* upstream/master: add new npm deps with improved gulp for dev (#328)
* upstream/master: Update version of inversify package (#329)
* upstream/master: Document our dev process (#330)
* upstream/master: Document contribution to the code along with coding standards (#321)
* upstream/master: Add Simplified Chinese translation of commands (#240)
* upstream/master: Fix package.json (#347)
* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)
* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)
* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)
* upstream/master: Use new environment variable parser (#362)
* upstream/master: Fetch tooltip details on-demand for auto-completions (#368) Fix interpreter display (#391)
* upstream/master: Fix typo in completion details (#396) Fix encoding (#394)
* upstream/master: Fix hover test (#398)
* upstream/master: Fix unicode unit test (#400)
* upstream/master: Pass execution arguments to linter when run as a stand alone executable (#406)
DonJayamanne
changed the title
DonJayamanne
changed the title
brettcannon
approved these changes
Dec 15, 2017
package.json
Outdated
| }, | ||
| "host": { | ||
| "type": "string", | ||
| "description": "IP Address of the of the local debug server (default is localhost or use 127.0.0.1).", |
There was a problem hiding this comment.
"IP address" and I would drop the "127.0.0.1" mention since the default works.
| @@ -45,24 +29,24 @@ export class UnitTestSocketServer extends EventEmitter implements IUnitTestSocke | |||
| this.server = undefined; | |||
| } | |||
| } | |||
| public start(): Promise<number> { | |||
| public start(options: { port?: number, host?: string } = { port: 0, host: 'localhost' }): Promise<number> { | |||
There was a problem hiding this comment.
Since this whole options type keeps being defined in a couple of places should it be put somewhere to be shared?
There was a problem hiding this comment.
At this stage no. We have a common setting in some places. But that cannot be shared.
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2018
* upstream/master: Make use of new execution layer instead of spawning processes (#425) Use localhost instead of 0.0.0.0 for all local socket servers (#417) Provide full signature help with highlighted parameter (#416) Change `os.arch()` to `npm` `arch` to fix wrong arch detection. (#419) Document our Russian support (#424) Bump the version number to the next release as an alpha (#422) Russian translation (#411) Speed up virtual environment detection in workspace (#405)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
Fixes #227