Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parsing of environment variables #466

Merged
merged 77 commits into from
Jan 3, 2018

Conversation

DonJayamanne
Copy link

Refactor how environment variables are parsed and used in tools, language server and debugger

octref and others added 30 commits November 3, 2017 13:11
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master:
  Fix typo in README.md (#252)
  Disable linter without workspaces (#241)
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
* upstream/master:
  Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
  Fixes #22 to Detect anaconda from known locations  (#221)
  Use workspaceFolder token instead of workspaceRoot (#267)
  Fix registry lookup response (#224)
  Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master:
  Fix debugging tests (#304)
* upstream/master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* upstream/master:
  Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master:
  Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master:
  Fix travis build error (#326)
* upstream/master:
  add new npm deps with improved gulp for dev (#328)
* upstream/master:
  Update version of inversify package (#329)
* upstream/master:
  Document our dev process (#330)
* upstream/master:
  Document contribution to the code along with coding standards (#321)
* upstream/master:
  Add Simplified Chinese translation of commands (#240)
* upstream/master:
  Fix package.json (#347)
* upstream/master:
  #34, #110 - suppress Intellisense in strings and comments (#339)
  Re-factor code python execution framework  (#345)
* upstream/master:
  Fix linters to make use of the new python code execution framework (#360)
  Update the versioning scheme (#356)
  Make npm happy in regards to line endings (#357)
* upstream/master:
  Ensure python path is not set if already set in user settings (#369)
  Use 'an' rather than 'a' before vowel words (#373)
* upstream/master:
  Use new environment variable parser (#362)
@DonJayamanne DonJayamanne changed the title WIP - Refactor parsing of environment variables WIP - Refactor parsing of environment variables (after 439) Dec 21, 2017
@DonJayamanne DonJayamanne changed the title WIP - Refactor parsing of environment variables (after 439) Refactor parsing of environment variables (after 439) Jan 3, 2018
@DonJayamanne
Copy link
Author

@brettcannon @MikhailArkhipov This PR is ready for review. please could one of you assign to your self and review at your convenience.

type VoidAction = (...params: {}[]) => void;

/**
* Debounces a function execution. Function must return either a void or a promise that resolves to a void.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "debouncing"?

@DonJayamanne DonJayamanne merged commit 576d50d into microsoft:master Jan 3, 2018
@DonJayamanne DonJayamanne changed the title Refactor parsing of environment variables (after 439) Refactor parsing of environment variables Jan 3, 2018
@DonJayamanne DonJayamanne deleted the EnvVarFixes branch January 4, 2018 19:49
DonJayamanne added a commit that referenced this pull request Jan 9, 2018
* upstream/master:
  Refactor parsing of environment variables (after 439) (#466)
  Refactor extension to remove old way of spawning python processes (#439)
DonJayamanne added a commit that referenced this pull request Jan 9, 2018
* CommonToolExecution:
  Refactor parsing of environment variables (after 439) (#466)
  Refactor extension to remove old way of spawning python processes (#439)
DonJayamanne added a commit that referenced this pull request Jan 9, 2018
* CommonToolExecution:
  Refactor parsing of environment variables (after 439) (#466)
  Refactor extension to remove old way of spawning python processes (#439)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants