Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements flag "containsBalancedBrackets" #170

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Implements flag "containsBalancedBrackets" #170

merged 4 commits into from
Apr 7, 2022

Conversation

hediet
Copy link
Member

@hediet hediet commented Apr 6, 2022 •
edited
Loading

Follow ups:

  • Ensure that many foreground-colors don't cause an overflow for background colors, as only 255 different colors are now available for the background and both background and foreground colors share the same color pool.
  • Refactor the code. Use the trie to check for this selector.

@hediet hediet force-pushed the hediet/containsBalancedBrackets branch from 9ae9e4d to 2d4d3c8 Compare April 6, 2022 22:30
@hediet hediet requested a review from alexdima April 6, 2022 22:32
@hediet hediet mentioned this pull request Apr 6, 2022
Merged
@alexdima alexdima merged commit 12f0e7a into main Apr 7, 2022
@alexdima alexdima deleted the hediet/containsBalancedBrackets branch April 7, 2022 12:16
@josecelano josecelano mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hediet @alexdima