Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopts "containsBalancedBrackets" flag from vscode/text-mate. #146962

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

hediet
Copy link
Member

@hediet hediet commented Apr 6, 2022

Requires microsoft/vscode-textmate#170
(thus build will fail)

Fixes #144736

@hediet hediet self-assigned this Apr 6, 2022
@hediet hediet added this to the April 2022 milestone Apr 6, 2022
@hediet hediet requested a review from alexdima April 6, 2022 22:43
@alexdima
Copy link
Member

alexdima commented Apr 7, 2022

I suggest to first wait for #147015 which does the strict necessary to adopt the latest version of vscode-textmate. Then we can use this PR to implement the feature.

@hediet hediet force-pushed the hediet/containsBalancedBrackets branch from b9d4862 to 584b886 Compare April 12, 2022 09:25
@hediet hediet force-pushed the hediet/containsBalancedBrackets branch from 584b886 to 2b14c47 Compare April 12, 2022 10:22
@hediet hediet merged commit 82e645c into main Apr 12, 2022
@hediet hediet deleted the hediet/containsBalancedBrackets branch April 12, 2022 10:40
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use textmate grammar token kind to exclude unbalanced brackets from being colorized
2 participants