testing: make ui more clear for discovery errors

Fixes #196546
microsoft · Oct 31, 2023 · 96511b7 · 96511b7
1 parent db16afc
commit 96511b7
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/.vscode-test.js b/.vscode-test.js
@@ -84,4 +84,4 @@ module.exports = defineConfig(extensions.map(extension => {
  }
 
  return config;
-}));
+})
diff --git a/src/vs/workbench/contrib/testing/browser/explorerProjections/index.ts b/src/vs/workbench/contrib/testing/browser/explorerProjections/index.ts
@@ -164,9 +164,11 @@ export const getChildrenForParent = (serialized: ISerializedTestTreeCollapseStat
  : {
  element,
  collapsible: element.test.expand !== TestItemExpandState.NotExpandable,
- collapsed: isCollapsedInSerializedTestTree(serialized, element.test.item.extId) ?? element.depth > 0
- ? ObjectTreeElementCollapseState.PreserveOrCollapsed
- : ObjectTreeElementCollapseState.PreserveOrExpanded,
+ collapsed: element.test.item.error
+ ? ObjectTreeElementCollapseState.Expanded
+ : (isCollapsedInSerializedTestTree(serialized, element.test.item.extId) ?? element.depth > 0
+ ? ObjectTreeElementCollapseState.PreserveOrCollapsed
+ : ObjectTreeElementCollapseState.PreserveOrExpanded),
  children: getChildrenForParent(serialized, rootsWithChildren, element),
  }
  ));

diff --git a/src/vs/workbench/contrib/testing/browser/media/testing.css b/src/vs/workbench/contrib/testing/browser/media/testing.css
@@ -111,6 +111,16 @@
  display: none;
 }
 
+.test-explorer .monaco-list-row .error {
+ outline: 1px solid var(--vscode-inputValidation-errorBorder);
+ background: var(--vscode-inputValidation-errorBackground);
+ padding: 2px 4px;
+ border-radius: 2px;
+ margin: 3px 12px 3px 3px;
+ line-height: 17px;
+ font-size: 12px;
+}
+
 .test-explorer .monaco-list-row .error p {
  margin: 0;
 }

diff --git a/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts b/src/vs/workbench/contrib/testing/browser/testingExplorerView.ts
@@ -1280,8 +1280,8 @@ class TreeKeyboardNavigationLabelProvider implements IKeyboardNavigationLabelPro
 }
 
 class ListDelegate implements IListVirtualDelegate<TestExplorerTreeElement> {
- getHeight(_element: TestExplorerTreeElement) {
- return 22;
+ getHeight(element: TestExplorerTreeElement) {
+ return element instanceof TestTreeErrorMessage ? 17 + 10 : 22;
  }
 
  getTemplateId(element: TestExplorerTreeElement) {