Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test UI could me clearer on discovery errors #196546

Closed
chrmarti opened this issue Oct 25, 2023 · 0 comments
Closed

Test UI could me clearer on discovery errors #196546

chrmarti opened this issue Oct 25, 2023 · 0 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
November 2023

Comments

@chrmarti
Copy link
Contributor

Testing #196332

It shows the error's message, but doesn't make explicit that there was an error thrown.

Image

This is from:

throw new Error('just throwing some error');
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Oct 25, 2023
@connor4312 connor4312 mentioned this issue Oct 31, 2023
Merged
connor4312 added a commit that referenced this issue Oct 31, 2023
@connor4312
testing: make ui more clear for discovery errors
96511b7 
Fixes #196546
connor4312 added a commit that referenced this issue Oct 31, 2023
@connor4312
testing: make ui more clear for discovery errors (#197115)
9dc8807 
* testing: make ui more clear for discovery errors

Fixes #196546

* undo
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 1, 2023
@vscodenpa vscodenpa added this to the November 2023 milestone Nov 1, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

No branches or pull requests
4 participants
@connor4312 @chrmarti @joyceerhl @vscodenpa