testing: make ui more clear for discovery errors #197115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
reviewed
Oct 31, 2023
.vscode-test.js
Outdated
| @@ -84,4 +84,4 @@ module.exports = defineConfig(extensions.map(extension => { | |||
| } | |||
|
|
|||
| return config; | |||
| })); | |||
| }) | |||
There was a problem hiding this comment.
is this deletion intentional?
andreamah
approved these changes
Oct 31, 2023
connor4312
added a commit
that referenced
this pull request
Nov 1, 2023
* cli: explicitly deny anonymous control port access Prevents inheriting any ACL set at the tunnel level which may allow different access for forwarded ports * testing: make ui more clear for discovery errors (#197115) * testing: make ui more clear for discovery errors Fixes #196546 * undo * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196546