Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow disabling auth extensions while being used by settings sync #103405

Closed
sandy081 opened this issue Jul 27, 2020 · 4 comments
Closed

Disallow disabling auth extensions while being used by settings sync #103405

sandy081 opened this issue Jul 27, 2020 · 4 comments
Assignees
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Currently one can disable an auth extension that provides auth token for settings sync.

We shall disallow this.

@sandy081 sandy081 added settings-sync authentication Issues with the Authentication platform labels Jul 27, 2020
@sandy081 sandy081 added this to the July 2020 milestone Jul 27, 2020
@sandy081
Copy link
Member Author

sandy081 commented Jul 27, 2020

@RMacfarlane This needs extension declaring auth providers through package.json. By doing so, we can detect if an extension is contributing an auth provider and check if those auth providers are being used for settings sync or not and prevent it from disabling.

This also helps settings sync to have deterministic initialisation - wait until providers are registered and initialise.

@sandy081
Copy link
Member Author

@RMacfarlane Is there a request to track static contributions for authentication providers?

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jul 28, 2020
@RMacfarlane
Copy link
Contributor

Yeah, here's the issue for it: #103507

@RMacfarlane RMacfarlane modified the milestones: July 2020, August 2020 Aug 3, 2020
@sandy081 sandy081 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Aug 29, 2020
sandy081 added a commit that referenced this issue Aug 29, 2020
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 1, 2020
@sandy081
Copy link
Member Author

sandy081 commented Sep 1, 2020

To verify:

  • Make sure you can disable auth provider extensions (Github/Microsoft) can be disabled only globally.
  • Disabling these extensions at workspace level is not allowed
  • If Settings Sync is on and using one of these accounts, Make sure you cannot disable that extension at all.

@connor4312 connor4312 added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@connor4312 @RMacfarlane @sandy081 and others