Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication providers, investigate static registration #103507

Closed
RMacfarlane opened this issue Jul 28, 2020 · 0 comments
Closed

Authentication providers, investigate static registration #103507

RMacfarlane opened this issue Jul 28, 2020 · 0 comments
Assignees
Labels
api-proposal authentication Issues with the Authentication platform feature-request Request for new features or functionality on-testplan
Milestone

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Jul 28, 2020

Follow up from #100993 (comment)

The one piece that did not make it in from above is providers and onDidChangeAuthenticationProviders. My hope was to get rid of the need for onDidChangeAuthenticationProviders by having auth provider extensions statically register themselves so that providers could be accurate at startup. However, I haven't found a way to implement this with providers being sync - resolving contribution points from package.json is async (and also currently things handling this live in the renderer), so the ext host piece would need to block on this.

One option is to leave it as it currently is, which means that consumers would have to subscribe to onDidChangeAuthenticationProviders to see if the provider they're looking for is registered. Another is to make providers back into getProviders, an async function, which would eliminate the need for static registration and could activate the auth provider extension in the same way that getSession does.

For the static registration, the contribution point could look like:

"authentication": [
    {
        "label": "GitHub",
        "id": "github"
    }
]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-proposal authentication Issues with the Authentication platform feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

1 participant