Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: Clear should not yank focus to the terminal #105491

Closed
cemerick opened this issue Aug 27, 2020 · 0 comments · Fixed by #107454
Closed

Terminal: Clear should not yank focus to the terminal #105491

cemerick opened this issue Aug 27, 2020 · 0 comments · Fixed by #107454
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@cemerick
Copy link

  • VSCode Version: 1.48.2
  • OS Version: Ubuntu 18.04.5

Steps to Reproduce:

  1. Have an integrated terminal open
  2. Focus an editor
  3. Trigger the Terminal: Clear command
  4. Notice that your focus is no longer in the editor

Does this issue occur when all extensions are disabled?: Yes

ezgif-6-eb4c6365f6fc

This is a relatively recent change, via #92076 and #92100. It can make working with e.g. watchers (as used by many common build / iterative testing toolchains) much less convenient, since one now needs to take multiple actions to clear the terminal before saving changes and thus triggering a build or test or linter run, etc.

The solution (taking into account the original issue #92076 and looking at @jheiv's change @ jheiv@0db5731) would be to ensure that focus is returned to the current component (whether an editor or the terminal)…or even better, identify why and how calling .clear() on a terminal instance causes focus to move at all in the first place.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues labels Sep 9, 2020
@Tyriar Tyriar added this to the Backlog milestone Sep 9, 2020
turara added a commit to turara/vscode that referenced this issue Sep 25, 2020
Remove unnecessary ITerminalInstance#focus method call.
@meganrogge meganrogge added the verified Verification succeeded label Nov 4, 2020
@rzhao271 rzhao271 added confirmed Issue has been confirmed by VS Code Team member and removed verified Verification succeeded labels Nov 5, 2020
@rzhao271 rzhao271 modified the milestones: Backlog, June 2021 Jul 2, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@cemerick @Tyriar @rzhao271 @meganrogge and others