Fixes [Terminal: Clear] command #107454
Merged
Fixes [Terminal: Clear] command #107454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary ITerminalInstance#focus method call.
|
@Tyriar Hi. Should I merge the master branch? Or is there anything I need to do about the VS Code check? |
Tyriar
approved these changes
Jun 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #105491: a bug of
Terminal: Clearcommand stealing focus from an editor or other components.I have deleted
t.focus()fromClearTerminalAction#runmethod in this PR to prevent the command from stealing focus.As mentioned in #105491, this line was originally added in #92100 to fix #92076. However I believe Restore focus (#93055) commit was enough to fix #92076.