-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started images for light theme would look better and be more helpful #115327
Comments
Right now all images for codespaces specifically are all light while all VS Code specific ones are dark. As the original focus is codespaces, I can make all images using the light theme for now. Vector images that pick up the theme colors might eventually help with this. |
@Tyriar are you suggesting all the images be light always or that we have two sets of images for light/dark themes? |
A different set of images for each theme. |
Images can now be optionally specified as |
Added support for light theme images but it isn't out on all items. I believe "settings" is the only one to support. We can keep this issue open to track adopting the new API. |
Fixed by f7cc0f2. |
\closedWith f7cc0f2 |
Maybe this isn't worth the effort because the dark theme is the default, but a light theme would not only make things look nicer but also be more helpful because the image will actually look like what it's trying to teach.
The text was updated successfully, but these errors were encountered: