Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started images for light theme would look better and be more helpful #115327

Closed
Tyriar opened this issue Jan 28, 2021 · 9 comments
Closed
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2021

Maybe this isn't worth the effort because the dark theme is the default, but a light theme would not only make things look nicer but also be more helpful because the image will actually look like what it's trying to teach.

image

@digitarald
Copy link
Contributor

Right now all images for codespaces specifically are all light while all VS Code specific ones are dark.

As the original focus is codespaces, I can make all images using the light theme for now. Vector images that pick up the theme colors might eventually help with this.

@JacksonKearl
Copy link
Contributor

@Tyriar are you suggesting all the images be light always or that we have two sets of images for light/dark themes?

@JacksonKearl JacksonKearl added getting-started under-discussion Issue is under discussion for relevance, priority, approach labels Jan 28, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Jan 28, 2021

A different set of images for each theme.

@JacksonKearl JacksonKearl added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jan 28, 2021
@JacksonKearl JacksonKearl added this to the February 2021 milestone Jan 28, 2021
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Feb 4, 2021

Images can now be optionally specified as {light: 'light/somepath', dark: 'dark/somepath', hc: 'hc/somepath'}, included an example for settings.png

JacksonKearl pushed a commit that referenced this issue Feb 4, 2021
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Feb 23, 2021
@bpasero
Copy link
Member

bpasero commented Feb 24, 2021

I still see dark images:

image

@bpasero bpasero reopened this Feb 24, 2021
@bpasero bpasero added the verification-found Issue verification failed label Feb 24, 2021
@JacksonKearl
Copy link
Contributor

Added support for light theme images but it isn't out on all items. I believe "settings" is the only one to support. We can keep this issue open to track adopting the new API.

@JacksonKearl JacksonKearl removed the verification-found Issue verification failed label Feb 24, 2021
digitarald added a commit that referenced this issue Mar 25, 2021
@digitarald
Copy link
Contributor

Fixed by f7cc0f2.

@rzhao271
Copy link
Contributor

\closedWith f7cc0f2

@rzhao271 rzhao271 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Mar 26, 2021
@rzhao271
Copy link
Contributor

High-contrast images for the steps shown in the screenshot seem to be missing

hc-missing

@rzhao271 rzhao271 reopened this Mar 26, 2021
@TylerLeonhardt TylerLeonhardt added the candidate Issue identified as probable candidate for fixing in the next release label Mar 26, 2021
@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Mar 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@digitarald @bpasero @Tyriar @TylerLeonhardt @rzhao271 @JacksonKearl and others