Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Release notes in the product #12520

Closed
2 tasks done
joaomoreno opened this issue Sep 23, 2016 · 3 comments
Closed
2 tasks done

Test: Release notes in the product #12520

joaomoreno opened this issue Sep 23, 2016 · 3 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 23, 2016

complexity: 2 bananas (out of 5 fruits)

Use the dev tools to control when to show the New version message at startup:

image

  1. Change the storage://global/releasenotes/lastversion value to an older version
  2. Reload. You should get the popup asking whether you'd like to read the release notes

The release notes now show in-product. Make sure they look OK and display images. If for any reason they fail to load, a browser window should open to the release notes link, just as before.

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2016

@joaomoreno how do I test this in Insiders? I tried setting the version in package.json but it didn't make a difference. See #12792

@joaomoreno
Copy link
Member Author

If you set the version in package.json to 1.5.0 and get the message, it should work. In any error case (no internet, firewall blocking, etc) you'll get redirected to the browser just as before.

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2016

K, got it to work. The problem is 1.6.0 doesn't have notes I assume.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants