Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard navigation doesn't work initially with in-product release notes #13264

Closed
gregvanl opened this issue Oct 5, 2016 · 3 comments
Closed

keyboard navigation doesn't work initially with in-product release notes #13264

gregvanl opened this issue Oct 5, 2016 · 3 comments
Assignees
@joaomoreno
Labels
verified Verification succeeded
Milestone
October 2016

Comments

@gregvanl
Copy link

gregvanl commented Oct 5, 2016 •
edited
Loading

  • VSCode Version:1.6.0 insiders
  • OS Version:Windows 10

Steps to Reproduce:

  1. Follow test plan to enable in product release notes in insiders Test: Release notes in the product #12520
  2. Help > Release Notes
  3. Try up/down/pageup/pagedown

The editor is not scrolled. Only if you click on the editor, does keyboard navigation start to work.
This is also the case if you go to another editor and then click the tabbed header or use Quick Open to activate the release notes.
@egamma egamma added the candidate Issue identified as probable candidate for fixing in the next release label Oct 6, 2016
@egamma egamma added this to the September 2016 milestone Oct 6, 2016
joaomoreno added a commit that referenced this issue Oct 7, 2016
@joaomoreno
fixes #13264
e240ede
@joaomoreno
Copy link
Member

Cherry picked to release/1.6

joaomoreno added a commit that referenced this issue Oct 7, 2016
@joaomoreno
Revert "fixes #13264"
0e7c3db 
This reverts commit e240ede.
@joaomoreno
Copy link
Member

Rolled back cherry pick. Removing it from candidates. Can't merge this in without merging #12982 which wasn't properly smoke tested.

@chrmarti
Copy link
Contributor

chrmarti commented Oct 7, 2016

Removing candidate label and updating milestone to October.

@chrmarti chrmarti removed the candidate Issue identified as probable candidate for fixing in the next release label Oct 7, 2016
@chrmarti chrmarti modified the milestones: October 2016, September 2016 Oct 7, 2016
@gregvanl gregvanl added the verified Verification succeeded label Oct 11, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
4 participants
@joaomoreno @egamma @chrmarti @gregvanl