Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linked editing with text containing a hyphen does not work in XML #127323

Closed
datho7561 opened this issue Jun 28, 2021 · 2 comments · Fixed by #127334
Closed

Linked editing with text containing a hyphen does not work in XML #127323

datho7561 opened this issue Jun 28, 2021 · 2 comments · Fixed by #127334
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders languages-basic Basic language support issues verified Verification succeeded
Milestone
June 2021

Comments

@datho7561
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No

  • VS Code Version:
    1.57.1
    507ce72
    x64
  • OS Version:
    Fedora Linux 34
    Kernel: 5.12.12-300.fc34.x86_64

Steps to Reproduce:

  1. Write an extension which provides linkedEditing for XML documents that does not return a wordPattern in the response (the redhat.vscode-xml snapshot build provides this feature and is available here)
  2. Set editor.linkedEditing to true
  3. Make an element with a hyphen in the name (eg. <web-app></web-app>)
  4. Place the cursor in the opening tag
  5. web-app in the opening and closing tag will be highlighted red
  6. Modify the opening tag
  7. The closing tag doesn't change to match the opening tag
datho7561 added a commit to datho7561/vscode that referenced this issue Jun 28, 2021
@datho7561
Add wordPattern for XML and XSL languages
8df6a36 
Closes microsoft#127323

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 28, 2021
Merged
datho7561 added a commit to datho7561/vscode that referenced this issue Jun 28, 2021
@datho7561
Add wordPattern for XML and XSL languages
27c1246 
Closes microsoft#127323

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Copy link
Contributor Author

The version of vscode-xml with linked editing support is now available from the marketplace, so you don't need to download the snapshot build if you are going to test using it.

datho7561 added a commit to datho7561/vscode that referenced this issue Jun 28, 2021
@datho7561
Add wordPattern for XML and XSL languages
4f58a1f 
Closes microsoft#127323

Signed-off-by: David Thompson <davthomp@redhat.com>
@aeschli
Copy link
Contributor

aeschli commented Jun 29, 2021

I see our XML word pattern doesn't include the -.
Thanks for the PR!

@aeschli aeschli added this to the June 2021 milestone Jun 29, 2021
@aeschli aeschli added languages-basic Basic language support issues bug Issue identified by VS Code Team member as probable bug labels Jun 29, 2021
@mjbvz mjbvz added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Add wordPattern for XML and XSL languages datho7561/vscode
4 participants
@aeschli @mjbvz @datho7561 and others